Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include discarded rules in rule check #1653

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

didroe
Copy link
Contributor

@didroe didroe commented Jul 16, 2024

Description

Don't return the error default rules could not be downloaded or possibly disabled... when rules were loaded but discarded due to no target files to scan.

Checklist

If this is your first time contributing please sign the CLA

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.

@didroe didroe merged commit a179682 into main Jul 16, 2024
8 checks passed
@didroe didroe deleted the fix/dont-fail-non-text-with-zero-rules branch July 16, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants